docs: update build instructions in readme and contributing guide #3373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sis0k0 we may add |
rosen-vladimirov
approved these changes
Feb 18, 2018
|
@rosen-vladimirov, yep that makes sense. Should we include the |
|
@sis0k0 sure, adding the command |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial
npm installin the repo is reporting errors because of the postinstall script, which expects that the 'ts' files are already transpiled. Maybe we should suggest running it with--ignore-scripts?The other change is running grunt from the local installation of the package, because you may not have a global instance. Maybe the grunt invocation can be moved to a npm script?